This repository has been archived by the owner on Sep 11, 2024. It is now read-only.
Allow creating permalinks for unknown predecessor rooms (even though unlikely to be successful) #10113
+6
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…unlikely to be successful)
justjanne
added
the
T-Defect
|
If this lands I think it warrants reopening element-hq/element-web#2925 as that was closed as everything moved to vias, this regresses that |
| if (prevRoom) { | ||
| permalinkCreator.load(); | ||
| } else { | ||
| logger.warn(`Creating permalink for unknown predecessor room ${predecessor.roomId}, unlikely to be successful`); |
There was a problem hiding this comment.
Suggested change
| logger.warn(`Creating permalink for unknown predecessor room ${predecessor.roomId}, unlikely to be successful`); | |
| logger.warn(`Creating permalink for unknown predecessor room ${predecessor.roomId}, it's possible that this room doesn't actually exist but we will give the user what they want`); |
There was a problem hiding this comment.
Alternative and probably more accurate than my first suggestion:
Suggested change
| logger.warn(`Creating permalink for unknown predecessor room ${predecessor.roomId}, unlikely to be successful`); | |
| logger.warn(`Creating permalink for unknown predecessor room ${predecessor.roomId}, unlikely to be routable on its own without via servers but we will give the user what they want`); |
There was a problem hiding this comment.
Suggested change
| logger.warn(`Creating permalink for unknown predecessor room ${predecessor.roomId}, unlikely to be successful`); | |
| logger.warn(`Creating permalink for unknown predecessor room ${predecessor.roomId},`+ | |
| 'unlikely to be successful as rooms without via servers are usually not routable'); |
There was a problem hiding this comment.
The phrasing here makes successful ambiguous about what will be successful. It kinda makes it seem like creating the permalink is unlikely to be successful.
Whereas I think we're trying to explain that a permalink for a random room ID is unlikely to get the user to right place.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type: Defect
Partially fixes: element-hq/element-web#24453
Reopens: element-hq/element-web#2925
Here's what your changelog entry will look like:
🐛 Bug Fixes